Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abr-testing): add plate reader + tartrazine protocol #16920

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

rclarke0
Copy link
Contributor

Overview

Adds protocol that uses tartrazine and takes plate reader measurements

Test Plan and Hands on Testing

  • passed simulate test and runs on robot

Changelog

  • removed OT3 ABR Normalize with Tubes protocol
  • added plate reader + tartrazine protocol

Review requests

Risk assessment

@rclarke0 rclarke0 requested a review from a team as a code owner November 20, 2024 21:38
Copy link
Contributor

@AnthonyNASC20 AnthonyNASC20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rclarke0 rclarke0 merged commit 49454f0 into edge Nov 21, 2024
21 checks passed
@rclarke0 rclarke0 deleted the abr-plate-reader-tart branch November 21, 2024 22:57
SyntaxColoring added a commit that referenced this pull request Nov 26, 2024
Conflicts:

api/src/opentrons/protocol_engine/commands/absorbance_reader/read.py:
Conflict in error message wording between PR #16941 in release and PR #16920 in edge. I took the one in release because the one in edge was an outdated cherry pick.

app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderModalContainer/hooks/useRunHeaderDropTip.ts:
Just import statements.

app/src/organisms/DropTipWizardFlows/hooks/useTipAttachmentStatus/getPipettesWithTipAttached.ts:
Release removed `cursor: null` and `includeFixitCommands: null` from some network requests, leaving those fields unspecified instead (PR ##16893). Edge deleted this whole file in favor of a different one (PR #16904). I removed `cursor: null` from the new file; `includeFixitCommands: null` was already removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants